[
https://issues.apache.org/jira/browse/GOBBLIN-1050?focusedWorklogId=393115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393115
]
ASF GitHub Bot logged work on GOBBLIN-1050:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/20 01:42
Start Date: 26/Feb/20 01:42
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on issue #2890: [GOBBLIN-1050]
Verify requester when updating/deleting FlowConfig
URL:
https://github.com/apache/incubator-gobblin/pull/2890#issuecomment-591191796
I did not like the idea of updating signature of update at multiple places.
It made the code non-uniform. Place of requesterList as a parameter in update()
is not quite justified in my opinion.
Is it possible to do checkRequester() in FlowConfigsResource::update/delete
instead of doing in resource handlers' update/delete ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 393115)
Time Spent: 40m (was: 0.5h)
> Verify requester when updating/deleting FlowConfig
> --------------------------------------------------
>
> Key: GOBBLIN-1050
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1050
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
