autumnust commented on a change in pull request #2892: GOBBLIN-1052: Create a
spec consumer path if it does not exist in FS …
URL: https://github.com/apache/incubator-gobblin/pull/2892#discussion_r382875432
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FsSpecConsumer.java
##########
@@ -55,10 +56,13 @@
private Map<URI, Path> specToPathMap = new HashMap<>();
- public FsSpecConsumer(Config config) {
+ public FsSpecConsumer(FileSystem fs, Config config) {
Review comment:
Since it is a public API, should we leave an option of
`FsSpecConsumer(Config config)` (by calling this constructor)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
