autumnust commented on a change in pull request #2892: GOBBLIN-1052: Create a 
spec consumer path if it does not exist in FS …
URL: https://github.com/apache/incubator-gobblin/pull/2892#discussion_r382875236
 
 

 ##########
 File path: 
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java
 ##########
 @@ -293,6 +294,10 @@ private static void deleteStoppedHelixJob(HelixManager 
helixManager, String work
     Map<String, WorkflowConfig> workflowConfigMap = taskDriver.getWorkflows();
     for (String workflow : workflowConfigMap.keySet()) {
       WorkflowConfig workflowConfig = taskDriver.getWorkflowConfig(workflow);
+      //Filter out any stale Helix workflows which are not running.
+      if (workflowConfig.getTargetState() != TargetState.START) {
 
 Review comment:
   Why filter out stopped job if the method call is to get a list of workFlowId 
from Gobblin job name ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to