sv2000 commented on a change in pull request #2900: [GOBBLIN-1040] HighLevelConsumer re-design by removing references to … URL: https://github.com/apache/incubator-gobblin/pull/2900#discussion_r386174327
########## File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/kafka/HighLevelConsumer.java ########## @@ -83,14 +95,58 @@ @Getter private MetricContext metricContext; private Counter messagesRead; - private ConsumerConnector consumer; - private ExecutorService executor; + @Getter + private final GobblinKafkaConsumerClient gobblinKafkaConsumerClient; + private final ScheduledExecutorService mainExecutor; Review comment: Use a more inuitive name instead of mainExecutor. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
