[
https://issues.apache.org/jira/browse/GOBBLIN-1069?focusedWorklogId=397852&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397852
]
ASF GitHub Bot logged work on GOBBLIN-1069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/20 20:30
Start Date: 04/Mar/20 20:30
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2908: [GOBBLIN-1069] Add
NPE check in handleContainerCompletion method
URL:
https://github.com/apache/incubator-gobblin/pull/2908#issuecomment-594817912
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2908?src=pr&el=h1)
Report
> Merging
[#2908](https://codecov.io/gh/apache/incubator-gobblin/pull/2908?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/dec3b91abb6ab3dc7223eaa3b19124cfe3c1d922?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2908?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2908 +/- ##
============================================
- Coverage 45.86% 45.85% -0.01%
+ Complexity 9187 9185 -2
============================================
Files 1934 1934
Lines 72856 72858 +2
Branches 8032 8033 +1
============================================
- Hits 33412 33410 -2
- Misses 36380 36383 +3
- Partials 3064 3065 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2908?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2908/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
| `15.23% <0%> (-0.09%)` | `4 <0> (ø)` | |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2908/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `78.12% <0%> (-1.57%)` | `15% <0%> (-1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2908/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.62% <0%> (-0.44%)` | `28% <0%> (-1%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2908?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2908?src=pr&el=footer).
Last update
[dec3b91...9ddf6b6](https://codecov.io/gh/apache/incubator-gobblin/pull/2908?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 397852)
Time Spent: 0.5h (was: 20m)
> Add NPE check in handleContainerCompletion method
> -------------------------------------------------
>
> Key: GOBBLIN-1069
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1069
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add NPE check in handleContainerCompletion method to make sure call the
> method twice for the same container will not fail the job
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
