[
https://issues.apache.org/jira/browse/GOBBLIN-1069?focusedWorklogId=397901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397901
]
ASF GitHub Bot logged work on GOBBLIN-1069:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/20 21:27
Start Date: 04/Mar/20 21:27
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2908:
[GOBBLIN-1069] Add NPE check in handleContainerCompletion method
URL: https://github.com/apache/incubator-gobblin/pull/2908#discussion_r387944305
##########
File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnService.java
##########
@@ -620,7 +620,10 @@ private boolean shouldStickToTheSameNode(int
containerExitStatus) {
*/
protected void handleContainerCompletion(ContainerStatus containerStatus) {
Map.Entry<Container, String> completedContainerEntry =
this.containerMap.remove(containerStatus.getContainerId());
-
+ if (completedContainerEntry == null) {
Review comment:
We have met some NPE when the container completion happens. And we alway add
the containerId to the map when one container is allocated and remove the id
only inside this method. So we assume that there may be chances that for one
completed container, this method will be called more than once. And in that
scenario (the method has already be called once to handle this completion), we
can say we no longer maintain this container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 397901)
Time Spent: 50m (was: 40m)
> Add NPE check in handleContainerCompletion method
> -------------------------------------------------
>
> Key: GOBBLIN-1069
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1069
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add NPE check in handleContainerCompletion method to make sure call the
> method twice for the same container will not fail the job
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
