[
https://issues.apache.org/jira/browse/GOBBLIN-1072?focusedWorklogId=399447&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-399447
]
ASF GitHub Bot logged work on GOBBLIN-1072:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/20 00:22
Start Date: 07/Mar/20 00:22
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2912: [GOBBLIN-1072]
Being more conservative on leasing containers
URL: https://github.com/apache/incubator-gobblin/pull/2912#discussion_r389193332
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java
##########
@@ -137,6 +154,13 @@ protected void shutDown() throws Exception {
private final int partitionsPerContainer;
private final int minContainers;
private final int maxContainers;
+ private final MaxValueEvictingQueue slidingFixedWindow;
+ private final HelixDataAccessor helixDataAccessor;
+ /**
+ * A static map that keep track of an idle instance and its latest
beginning idle time.
+ * If an instance is no long idle when inspected, it will be dropped from
this map.
Review comment:
no long -> no longer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 399447)
Time Spent: 1h 10m (was: 1h)
> Being more conservative on releasing YARN containers
> ----------------------------------------------------
>
> Key: GOBBLIN-1072
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1072
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
