[
https://issues.apache.org/jira/browse/GOBBLIN-1072?focusedWorklogId=399543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-399543
]
ASF GitHub Bot logged work on GOBBLIN-1072:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/20 05:34
Start Date: 07/Mar/20 05:34
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2912:
[GOBBLIN-1072] Being more conservative on leasing containers
URL: https://github.com/apache/incubator-gobblin/pull/2912#discussion_r389230335
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java
##########
@@ -189,16 +224,123 @@ void runInternal() {
}
}
+ // Find all participants appearing in this cluster. Note that Helix
instances can contain cluster-manager
+ // and potentially replanner-instance.
+ Set<String> allParticipants =
getParticipants(GobblinYarnTaskRunner.class.getSimpleName());
Review comment:
Good catch, I prefer to put that in `GobblinYarnTaskRunner` itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 399543)
Time Spent: 2h 20m (was: 2h 10m)
> Being more conservative on releasing YARN containers
> ----------------------------------------------------
>
> Key: GOBBLIN-1072
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1072
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
