[
https://issues.apache.org/jira/browse/GOBBLIN-1100?focusedWorklogId=411132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411132
]
ASF GitHub Bot logged work on GOBBLIN-1100:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/20 15:01
Start Date: 27/Mar/20 15:01
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2941: [GOBBLIN-1100]
Set average fetch time in the KafkaExtractor even when…
URL: https://github.com/apache/incubator-gobblin/pull/2941
… metrics are disabled
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1100
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
The KafkaExtractor close method only calls the
KafkaExtractorStatsTracker#emitTrackingEvents method when metrics
instrumentation is enabled. This method calls
KafkaExtractorStatsTracker#generateTagsForPartitions, which has the side effect
of setting the average fetch time in the WorkUnitState. The average fetch time
is required for the work unit packing to pack optimally.
Add a call to KafkaExtractorStatsTracker#generateTagsForPartitions in
KafkaExtractor#close when metrics instrumentation is disabled to restore the
behavior that existed prior to the KafkaExtractorStatsTracker refactoring.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
KafkaExtractorStatsTrackerTest
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411132)
Remaining Estimate: 0h
Time Spent: 10m
> Set average fetch time in the KafkaExtractor even when metrics are disabled
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-1100
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1100
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The KafkaExtractor close method only calls the
> KafkaExtractorStatsTracker#emitTrackingEvents method when metrics
> instrumentation is enabled. This method calls
> KafkaExtractorStatsTracker#generateTagsForPartitions, which has the side
> effect of setting the average fetch time in the WorkUnitState. The average
> fetch time is required for the work unit packing to pack optimally.
>
> Add a call to KafkaExtractorStatsTracker#generateTagsForPartitions in
> KafkaExtractor#close when metrics instrumentation is disabled to restore the
> behavior that existed prior to the KafkaExtractorStatsTracker refactoring.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
