[
https://issues.apache.org/jira/browse/GOBBLIN-1100?focusedWorklogId=411133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411133
]
ASF GitHub Bot logged work on GOBBLIN-1100:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/20 15:01
Start Date: 27/Mar/20 15:01
Worklog Time Spent: 10m
Work Description: htran1 commented on issue #2941: [GOBBLIN-1100] Set
average fetch time in the KafkaExtractor even when…
URL:
https://github.com/apache/incubator-gobblin/pull/2941#issuecomment-605048421
@autumnust, @sv2000, please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411133)
Time Spent: 20m (was: 10m)
> Set average fetch time in the KafkaExtractor even when metrics are disabled
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-1100
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1100
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Hung Tran
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The KafkaExtractor close method only calls the
> KafkaExtractorStatsTracker#emitTrackingEvents method when metrics
> instrumentation is enabled. This method calls
> KafkaExtractorStatsTracker#generateTagsForPartitions, which has the side
> effect of setting the average fetch time in the WorkUnitState. The average
> fetch time is required for the work unit packing to pack optimally.
>
> Add a call to KafkaExtractorStatsTracker#generateTagsForPartitions in
> KafkaExtractor#close when metrics instrumentation is disabled to restore the
> behavior that existed prior to the KafkaExtractorStatsTracker refactoring.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
