sv2000 commented on a change in pull request #2945: [GOBBLIN-1105] some
refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r401264580
##########
File path:
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/DatasetStoreDataset.java
##########
@@ -36,7 +38,8 @@
@Override
public String datasetURN() {
- return this.key.getStoreName() + ":::" + this.key.getSanitizedDatasetUrn();
+ return this.key.getStoreName() +
+ (StringUtils.isEmpty(this.key.getSanitizedDatasetUrn()) ? "" : ":::" +
this.key.getSanitizedDatasetUrn());
Review comment:
Nit: Guava's Strings.isNullOrEmpty() is more readable. I did not realize
until I saw the Javadoc for StringUtils.isEmpty that it returns true if the
string is null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
