zxcware commented on a change in pull request #2945: [GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r403204430
########## File path: gobblin-metastore/src/main/java/org/apache/gobblin/metastore/DatasetStateStore.java ########## @@ -56,7 +56,7 @@ public void persistDatasetURNs(String storeName, Collection<String> datasetUrns) throws IOException; @Override - default List<? extends DatasetStateStoreEntryManager> getMetadataForTables(StateStorePredicate predicate) + default List<? extends StateStoreEntryManager> getMetadataForTables(StateStorePredicate predicate) Review comment: For `DatasetStateStore`, should use `DatasetStateStoreEntryManager`, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
