[
https://issues.apache.org/jira/browse/GOBBLIN-1105?focusedWorklogId=415664&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415664
]
ASF GitHub Bot logged work on GOBBLIN-1105:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/20 18:44
Start Date: 03/Apr/20 18:44
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2945:
[GOBBLIN-1105] some refactoring and make MysqlJobStatusStateStore implements
DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r403237650
##########
File path:
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlJobStatusStateStore.java
##########
@@ -50,12 +61,63 @@ public MysqlJobStatusStateStore(DataSource dataSource,
String stateStoreTableNam
/**
* Returns all the job statuses for a flow group, flow name, flow execution
id
- * @param storeName
- * @param flowExecutionId
- * @return
- * @throws IOException
+ * @param storeName store name in the state store
+ * @param flowExecutionId Flow Execution Id
+ * @return list of states
+ * @throws IOException in case of failures
*/
public List<T> getAll(String storeName, long flowExecutionId) throws
IOException {
return getAll(storeName, flowExecutionId + "%", true);
}
+
+ @Override
+ public List<DatasetStateStoreEntryManager<T>>
getMetadataForTables(StateStorePredicate predicate)
Review comment:
This PR is only addressing the refactoring to support cleanup of job statuses
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 415664)
Time Spent: 2.5h (was: 2h 20m)
> make MysqlJobStatusStateStore implements DatasetStateStore
> ----------------------------------------------------------
>
> Key: GOBBLIN-1105
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1105
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> make MysqlJobStatusStateStore implements DatasetStateStore so that we can use
> existing cleaners/dataset finders/version finders to clean job status
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
