[
https://issues.apache.org/jira/browse/GOBBLIN-1105?focusedWorklogId=415115&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415115
]
ASF GitHub Bot logged work on GOBBLIN-1105:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/20 23:00
Start Date: 02/Apr/20 23:00
Worklog Time Spent: 10m
Work Description: zxcware commented on pull request #2945: [GOBBLIN-1105]
some refactoring and make MysqlJobStatusStateStore implements DatasetStateStore
URL: https://github.com/apache/incubator-gobblin/pull/2945#discussion_r402643365
##########
File path:
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/FsStateStore.java
##########
@@ -378,4 +387,48 @@ public void delete(String storeName) throws IOException {
this.fs.delete(storePath, true);
}
}
+
+ @Override
+ public Map<String, T> getLatestDatasetStatesByUrns(String jobName) throws
IOException {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public T getLatestDatasetState(String storeName, String datasetUrn) throws
IOException {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void persistDatasetState(String datasetUrn, T datasetState) throws
IOException {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void persistDatasetURNs(String storeName, Collection<String>
datasetUrns) throws IOException {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public List<? extends StateStoreEntryManager>
getMetadataForTables(StateStorePredicate predicate) {
Review comment:
Should it be `DatasetStateStoreEntryManager` to correct serve its role as
dataset state store?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 415115)
Time Spent: 1h 50m (was: 1h 40m)
> make MysqlJobStatusStateStore implements DatasetStateStore
> ----------------------------------------------------------
>
> Key: GOBBLIN-1105
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1105
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> make MysqlJobStatusStateStore implements DatasetStateStore so that we can use
> existing cleaners/dataset finders/version finders to clean job status
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
