arjun4084346 commented on a change in pull request #2907: [GOBBLIN-1068]Clean
up cyclic logic in task cancellation
URL: https://github.com/apache/incubator-gobblin/pull/2907#discussion_r404662868
##########
File path:
gobblin-cluster/src/test/java/org/apache/gobblin/cluster/ClusterIntegrationTest.java
##########
@@ -167,9 +171,20 @@ public void testJobRestartViaSpec() throws Exception {
return recordNew == null ||
targetStateNew.equals(TargetState.STOP.name());
}, "Waiting for Workflow TargetState to be STOP");
- //Ensure that the SleepingTask did not terminate normally i.e. it was
interrupted. We check this by ensuring
- // that the line "Hello World!" is not present in the logged output.
- suite.waitForAndVerifyOutputFiles();
+ // Ensure that the SleepingTask did not terminate normally i.e. it was
interrupted. We check this by ensuring
+ // that the line "Hello World!" is not present in the logged output but
only "Sleeping interrupted"
+ // It is important to have back-off here since ZNode STOP state doesn't
mean the actual sleeping task has been terminated
+ // since shutdown of task is async.
+
AssertWithBackoff.create().maxSleepMs(1000).timeoutMs(120000).backoffFactor(1).assertTrue(input
-> {
Review comment:
should be `maxSleepMs(1000L).timeoutMs(120000L)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
