arjun4084346 commented on a change in pull request #2907: [GOBBLIN-1068]Clean
up cyclic logic in task cancellation
URL: https://github.com/apache/incubator-gobblin/pull/2907#discussion_r405680816
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/GobblinMultiTaskAttempt.java
##########
@@ -372,9 +379,9 @@ private boolean taskSuccessfulInPriorAttempt(String
taskId) {
* @param countDownLatch a {@link java.util.concurrent.CountDownLatch}
waited on for job completion
* @return a list of {@link Task}s from the {@link WorkUnit}s
*/
- private List<Task> runWorkUnits(CountUpAndDownLatch countDownLatch) {
-
+ private Pair<List<Task>, List<Future<?>>> runWorkUnits(CountUpAndDownLatch
countDownLatch) {
Review comment:
How about returning List<Pair<Task, Future<?>> ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
