[jira] [Work logged] (GOBBLIN-1117) Fix hard-code avro suffix in record-count verification process for re-compaction

Tue, 14 Apr 2020 15:52:10 -0700 


     [ 
https://issues.apache.org/jira/browse/GOBBLIN-1117?focusedWorklogId=422402&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422402
 ]

ASF GitHub Bot logged work on GOBBLIN-1117:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Apr/20 22:51
            Start Date: 14/Apr/20 22:51
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2957: 
[GOBBLIN-1117]Enable record count verification for ORC format
URL: 
https://github.com/apache/incubator-gobblin/pull/2957#issuecomment-613719436
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2957?src=pr&el=h1)
 Report
   > Merging 
[#2957](https://codecov.io/gh/apache/incubator-gobblin/pull/2957?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/045abc17734cd3fdcd40c1317cca3db980ea0095&el=desc)
 will **decrease** coverage by `0.00%`.
   > The diff coverage is `70.58%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2957/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/2957?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2957      +/-   ##
   ============================================
   - Coverage     45.57%   45.56%   -0.01%     
   + Complexity     9174     9173       -1     
   ============================================
     Files          1938     1938              
     Lines         73427    73434       +7     
     Branches       8111     8112       +1     
   ============================================
   + Hits          33461    33463       +2     
   - Misses        36858    36865       +7     
   + Partials       3108     3106       -2     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2957?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...compaction/verify/CompactionThresholdVerifier.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2957/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vdmVyaWZ5L0NvbXBhY3Rpb25UaHJlc2hvbGRWZXJpZmllci5qYXZh)
 | `66.66% <61.53%> (-8.34%)` | `5.00 <0.00> (ø)` | |
   | 
[...he/gobblin/compaction/source/CompactionSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2957/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc291cmNlL0NvbXBhY3Rpb25Tb3VyY2UuamF2YQ==)
 | `72.16% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
   | 
[...blin/compaction/verify/InputRecordCountHelper.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2957/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vdmVyaWZ5L0lucHV0UmVjb3JkQ291bnRIZWxwZXIuamF2YQ==)
 | `79.24% <100.00%> (+0.39%)` | `14.00 <0.00> (ø)` | |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2957/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `37.30% <0.00%> (-3.18%)` | `15.00% <0.00%> (-1.00%)` | |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2957/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `67.91% <0.00%> (+0.37%)` | `33.00% <0.00%> (ø%)` | |
   | 
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2957/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
 | `80.37% <0.00%> (+0.93%)` | `24.00% <0.00%> (ø%)` | |
   | 
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2957/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
 | `62.85% <0.00%> (+1.42%)` | `4.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2957?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2957?src=pr&el=footer).
 Last update 
[045abc1...2ff4c08](https://codecov.io/gh/apache/incubator-gobblin/pull/2957?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 422402)
    Time Spent: 0.5h  (was: 20m)

> Fix hard-code avro suffix in record-count verification process for 
> re-compaction
> --------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1117
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1117
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to