[
https://issues.apache.org/jira/browse/GOBBLIN-1117?focusedWorklogId=423664&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423664
]
ASF GitHub Bot logged work on GOBBLIN-1117:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/20 19:11
Start Date: 16/Apr/20 19:11
Worklog Time Spent: 10m
Work Description: zxcware commented on pull request #2957:
[GOBBLIN-1117]Enable record count verification for ORC format
URL: https://github.com/apache/incubator-gobblin/pull/2957#discussion_r409787789
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/verify/InputRecordCountHelper.java
##########
@@ -71,6 +75,7 @@ public InputRecordCountHelper(State state) {
try {
this.fs = getSourceFileSystem (state);
this.state = state;
+ this.extensionName = state.getProp(COMPACTION_OUTPUT_EXTENSION,
DEFAULT_COMPACTION_OUTPUT_EXTENSION);
Review comment:
looks like it supports a list of extension as in line 97. How about using a
new config key that indicates it supports a extensions list? It also helps
decouple the configs between `InputRecordCountHelper` and
`CompactorOutputCommitter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 423664)
Time Spent: 50m (was: 40m)
> Fix hard-code avro suffix in record-count verification process for
> re-compaction
> --------------------------------------------------------------------------------
>
> Key: GOBBLIN-1117
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1117
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
