[
https://issues.apache.org/jira/browse/GOBBLIN-1116?focusedWorklogId=423095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423095
]
ASF GitHub Bot logged work on GOBBLIN-1116:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/20 22:01
Start Date: 15/Apr/20 22:01
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2956:
GOBBLIN-1116: Avoid registering schema with schema registry during Me…
URL: https://github.com/apache/incubator-gobblin/pull/2956#discussion_r408970490
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/util/EventUtils.java
##########
@@ -109,5 +110,47 @@ public synchronized static GobblinTrackingEvent
deserializeReportFromAvroSeriali
closer.close();
}
}
-}
+ /**
+ * Parses a {@link org.apache.gobblin.metrics.GobblinTrackingEvent} from a
byte array Avro serialization.
+ * @param reuse GobblinTrackingEvent to reuse.
+ * @param bytes Input bytes.
+ * @param schemaId Expected schemaId.
+ * @param schemaIdLengthBytes schemaId length in number of bytes.
+ * @return GobblinTrackingEvent.
+ * @throws java.io.IOException
+ */
+ public synchronized static GobblinTrackingEvent
deserializeEventFromAvroSerialization(GobblinTrackingEvent reuse, byte[] bytes,
String schemaId, int schemaIdLengthBytes)
Review comment:
This method's body is almost identical with
`deserializeEventFromAvroSerialization`. Can we call this in previous one ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 423095)
Time Spent: 0.5h (was: 20m)
> Avoid registering schema with schema registry during MetricReporting
> initialization from cluster workers
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1116
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1116
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This PR avoids having to register schema with schema registry on Kafka metric
> reporter initialization from cluster workers. This avoids a potentially large
> number of connections that may be initiated with Kafka Schema registry on
> Gobblin on Yarn application launch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
