[
https://issues.apache.org/jira/browse/GOBBLIN-1116?focusedWorklogId=424323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424323
]
ASF GitHub Bot logged work on GOBBLIN-1116:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/20 17:49
Start Date: 17/Apr/20 17:49
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2956: GOBBLIN-1116:
Avoid registering schema with schema registry during Me…
URL: https://github.com/apache/incubator-gobblin/pull/2956#discussion_r410377584
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/metrics/KafkaReportingFormats.java
##########
@@ -104,6 +113,10 @@ public ScheduledReporter buildEventsReporter(String
brokers, String topic, Metri
if
(Boolean.valueOf(properties.getProperty(ConfigurationKeys.METRICS_REPORTING_KAFKA_USE_SCHEMA_REGISTRY,
ConfigurationKeys.DEFAULT_METRICS_REPORTING_KAFKA_USE_SCHEMA_REGISTRY))) {
builder.withSchemaRegistry(new KafkaAvroSchemaRegistry(properties));
+ String schemaId =
properties.getProperty(ConfigurationKeys.METRICS_REPORTING_EVENTS_KAFKA_AVRO_SCHEMA_ID);
Review comment:
I did try to avoid duplication here. The problem stems from the fact that
the builders are of different classes and the common parent does not expose the
methods that would have avoided the duplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 424323)
Time Spent: 2h (was: 1h 50m)
> Avoid registering schema with schema registry during MetricReporting
> initialization from cluster workers
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1116
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1116
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> This PR avoids having to register schema with schema registry on Kafka metric
> reporter initialization from cluster workers. This avoids a potentially large
> number of connections that may be initiated with Kafka Schema registry on
> Gobblin on Yarn application launch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
