zxcware commented on a change in pull request #2957: [GOBBLIN-1117]Enable
record count verification for ORC format
URL: https://github.com/apache/incubator-gobblin/pull/2957#discussion_r409787789
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/verify/InputRecordCountHelper.java
##########
@@ -71,6 +75,7 @@ public InputRecordCountHelper(State state) {
try {
this.fs = getSourceFileSystem (state);
this.state = state;
+ this.extensionName = state.getProp(COMPACTION_OUTPUT_EXTENSION,
DEFAULT_COMPACTION_OUTPUT_EXTENSION);
Review comment:
looks like it supports a list of extension as in line 97. How about using a
new config key that indicates it supports a extensions list? It also helps
decouple the configs between `InputRecordCountHelper` and
`CompactorOutputCommitter`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
