autumnust commented on a change in pull request #2957: [GOBBLIN-1117]Enable
record count verification for ORC format
URL: https://github.com/apache/incubator-gobblin/pull/2957#discussion_r409836425
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/verify/InputRecordCountHelper.java
##########
@@ -71,6 +75,7 @@ public InputRecordCountHelper(State state) {
try {
this.fs = getSourceFileSystem (state);
this.state = state;
+ this.extensionName = state.getProp(COMPACTION_OUTPUT_EXTENSION,
DEFAULT_COMPACTION_OUTPUT_EXTENSION);
Review comment:
I think making this configurable in the first place is a mistake - the
extension should always stay consistent with the extension that you specified
as part of compaction job. I get the point of decouple the configs, but they
are needed in different places and that's why it is public static. ( If strict
decoupling is applied then anything should be private or package-private
static, which is not realistic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
