arjun4084346 commented on a change in pull request #2981:
URL: https://github.com/apache/incubator-gobblin/pull/2981#discussion_r422579180
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java
##########
@@ -325,12 +325,14 @@ public Spec getSpecWrapper(URI uri) {
return responseMap;
}
- private boolean isCompileSuccessful(Map<String, AddSpecResponse>
responseMap) {
+ public static boolean isCompileSuccessful(Map<String, AddSpecResponse>
responseMap) {
AddSpecResponse<String> addSpecResponse =
responseMap.getOrDefault(ServiceConfigKeys.GOBBLIN_SERVICE_JOB_SCHEDULER_LISTENER_CLASS,
new AddSpecResponse<>(""));
- return addSpecResponse != null
- && addSpecResponse.getValue() != null
- && !addSpecResponse.getValue().contains("ConfigException");
+ return isCompileSuccessful(addSpecResponse.getValue());
+ }
+
+ public static boolean isCompileSuccessful(String dag) {
Review comment:
Yes, we can move the method into gobblin-service module, but
gobblin-runtime (FlowCatalog) cannot have dependency on gobblin-service. That
means listeners have to return a map in AddSpecResponse if they want to pass
multiple information ( a) isCompileSuccessful b) compiledDag) to the caller.
Let me know if you want me implement it that way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
