sv2000 commented on a change in pull request #2981:
URL: https://github.com/apache/incubator-gobblin/pull/2981#discussion_r422700381
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java
##########
@@ -325,12 +325,14 @@ public Spec getSpecWrapper(URI uri) {
return responseMap;
}
- private boolean isCompileSuccessful(Map<String, AddSpecResponse>
responseMap) {
+ public static boolean isCompileSuccessful(Map<String, AddSpecResponse>
responseMap) {
AddSpecResponse<String> addSpecResponse =
responseMap.getOrDefault(ServiceConfigKeys.GOBBLIN_SERVICE_JOB_SCHEDULER_LISTENER_CLASS,
new AddSpecResponse<>(""));
- return addSpecResponse != null
- && addSpecResponse.getValue() != null
- && !addSpecResponse.getValue().contains("ConfigException");
+ return isCompileSuccessful(addSpecResponse.getValue());
+ }
+
+ public static boolean isCompileSuccessful(String dag) {
Review comment:
Understood. One option would be to relocate FlowCatalog inside
gobblin-service module. Not sure, if it will require a significant refactoring
effort, in which case, it is ok to leave it as-is and we can do the refactoring
in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
