[
https://issues.apache.org/jira/browse/GOBBLIN-1127?focusedWorklogId=435531&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-435531
]
ASF GitHub Bot logged work on GOBBLIN-1127:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/20 16:29
Start Date: 20/May/20 16:29
Worklog Time Spent: 10m
Work Description: sv2000 opened a new pull request #2992:
URL: https://github.com/apache/incubator-gobblin/pull/2992
…tantiatio…"
This reverts commit 239115778a08590d7ab5dfa32334efabe0e4fb49.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1153
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
The changes in PR 2967 introduce a backward incompatible behavior in metric
reporting failures where in: Failure in instantiating one of the configured
reporters, fails the entire reporting service. Previously, individual reporter
failures are swallowed allowing the rest of the reporting service to proceed.
The behavior introduced is PR 2967 may be too aggressive and might need a
re-think.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Existing unit tests.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 435531)
Time Spent: 1.5h (was: 1h 20m)
> Provide an option to make metric reporting instantiation failures fatal
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1127
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1127
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This option allows GobblinTaskRunner to "fail-fast" on metric reporting
> instantiation failures. This is particularly sseful in scenarios where
> pipeline monitoring depends on metrics and tracking events being emitted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
