[
https://issues.apache.org/jira/browse/GOBBLIN-1127?focusedWorklogId=446213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446213
]
ASF GitHub Bot logged work on GOBBLIN-1127:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jun/20 01:13
Start Date: 16/Jun/20 01:13
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3035:
URL:
https://github.com/apache/incubator-gobblin/pull/3035#issuecomment-642214083
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=h1)
Report
> Merging
[#3035](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc)
will **increase** coverage by `0.13%`.
> The diff coverage is `25.78%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3035 +/- ##
============================================
+ Coverage 45.66% 45.80% +0.13%
- Complexity 9296 9347 +51
============================================
Files 1956 1961 +5
Lines 74397 74547 +150
Branches 8247 8262 +15
============================================
+ Hits 33977 34145 +168
+ Misses 37242 37203 -39
- Partials 3178 3199 +21
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...ache/gobblin/compaction/mapreduce/MRCompactor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9yLmphdmE=)
| `7.04% <0.00%> (-0.10%)` | `9.00 <0.00> (ø)` | |
|
[...pache/gobblin/metrics/MetricReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9NZXRyaWNSZXBvcnRlckV4Y2VwdGlvbi5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...apache/gobblin/metrics/MultiReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9NdWx0aVJlcG9ydGVyRXhjZXB0aW9uLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...a/org/apache/gobblin/metrics/ReporterSinkType.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9SZXBvcnRlclNpbmtUeXBlLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[.../java/org/apache/gobblin/metrics/ReporterType.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9SZXBvcnRlclR5cGUuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...bblin/metrics/reporter/util/MetricReportUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci91dGlsL01ldHJpY1JlcG9ydFV0aWxzLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...org/apache/gobblin/azkaban/AzkabanJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Kb2JMYXVuY2hlci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...bblin/metrics/kafka/KafkaEventReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FFdmVudFJlcG9ydGVyRmFjdG9yeS5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...blin/metrics/kafka/KafkaMetricReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FNZXRyaWNSZXBvcnRlckZhY3RvcnkuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [35
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=footer).
Last update
[31f2ef1...fc0acb5](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 446213)
Time Spent: 3h (was: 2h 50m)
> Provide an option to make metric reporting instantiation failures fatal
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1127
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1127
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> This option allows GobblinTaskRunner to "fail-fast" on metric reporting
> instantiation failures. This is particularly sseful in scenarios where
> pipeline monitoring depends on metrics and tracking events being emitted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
