jack-moseley opened a new pull request #2993: URL: https://github.com/apache/incubator-gobblin/pull/2993
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1154 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): Variety of improvements to GaaS error returning: - When creating flowConfig, in case of error throw it instead of returning 4xx along with flowConfig. Returning the `CreateKVResponse` means that the the status is only seen if using `--verbose`, and there is no clear error message - Similarly return a more clear error message when calling get for a flowExecution that doesn't exist - Instead of concatenating execution links in the message field of flowStatus (this is not useful since they are already in the jobStatus list), use the message field to return a flow level error message - Added a `FlowCancelled` event so that flows that were SLA killed or manually killed will have a `CANCELLED` status instead of `FAILED` ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
