jack-moseley commented on a change in pull request #2993:
URL: https://github.com/apache/incubator-gobblin/pull/2993#discussion_r428919270
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -476,6 +476,9 @@ private void cancelDag(String dagToCancel) throws
ExecutionException, Interrupte
for (DagNode<JobExecutionPlan> dagNodeToCancel : dagNodesToCancel) {
cancelDagNode(dagNodeToCancel);
}
+
+
this.dags.get(dagToCancel).setFlowEvent(TimingEvent.FlowTimings.FLOW_CANCELLED);
Review comment:
This. is setting the flow event on a dag level, not a dag node level, so
it makes more sense to do it in cancelDag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
