[
https://issues.apache.org/jira/browse/GOBBLIN-1160?focusedWorklogId=438981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-438981
]
ASF GitHub Bot logged work on GOBBLIN-1160:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/20 23:32
Start Date: 29/May/20 23:32
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3011:
URL: https://github.com/apache/incubator-gobblin/pull/3011#discussion_r432781803
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -435,10 +454,17 @@ public void run() {
try {
GobblinServiceJobScheduler.this.runJob(this.jobConfig,
this.jobListener);
if (flowCatalog.isPresent() && removeSpec) {
+ while
(!GobblinServiceJobScheduler.this.flowCatalog.get().exists(specUri)) {
Review comment:
Should this block be replaced with a "wait with a timeout"? Is there a
chance this thread may wait forever? If so, we should avoid that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 438981)
Time Spent: 50m (was: 40m)
> do not delete spec on compilation failures at startup
> -----------------------------------------------------
>
> Key: GOBBLIN-1160
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1160
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> do not delete spec on compilation failures at service startup, because git
> flow graph and topology services might not have started yet.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
