[
https://issues.apache.org/jira/browse/GOBBLIN-1160?focusedWorklogId=439338&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439338
]
ASF GitHub Bot logged work on GOBBLIN-1160:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/20 04:10
Start Date: 01/Jun/20 04:10
Worklog Time Spent: 10m
Work Description: arjun4084346 opened a new pull request #3011:
URL: https://github.com/apache/incubator-gobblin/pull/3011
address review comments
improve test cases
code cleaning
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1160
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
1) store specs in spec store only when compilation passes
2) fix the race condition between NonScheduledJobRunner and FlowCatalog
threads
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
added a few unit tests
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 439338)
Time Spent: 1h 20m (was: 1h 10m)
> do not delete spec on compilation failures at startup
> -----------------------------------------------------
>
> Key: GOBBLIN-1160
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1160
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> do not delete spec on compilation failures at service startup, because git
> flow graph and topology services might not have started yet.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
