[
https://issues.apache.org/jira/browse/GOBBLIN-1187?focusedWorklogId=444666&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444666
]
ASF GitHub Bot logged work on GOBBLIN-1187:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/20 01:10
Start Date: 12/Jun/20 01:10
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3027:
URL: https://github.com/apache/incubator-gobblin/pull/3027#discussion_r439155559
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/job_catalog/NonObservingFSJobCatalog.java
##########
@@ -121,5 +125,11 @@ public synchronized void remove(URI jobURI) {
LOGGER.warn("No file with URI:" + jobURI + " is found. Deletion
failed.");
}
}
+
+ @Override
+ public synchronized void cancel(JobSpec jobSpec) {
+ Preconditions.checkState(state() == State.RUNNING, String.format("%s is
not running.", this.getClass().getName()));
Review comment:
Yea, the message is supposed to be "exception message to use if the
check fails" (from Preconditions# checkState () javadoc)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 444666)
Time Spent: 40m (was: 0.5h)
> cancel a gaas flow when the dag manager is disabled
> ---------------------------------------------------
>
> Key: GOBBLIN-1187
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1187
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
