[
https://issues.apache.org/jira/browse/GOBBLIN-1187?focusedWorklogId=444674&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444674
]
ASF GitHub Bot logged work on GOBBLIN-1187:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/20 01:39
Start Date: 12/Jun/20 01:39
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3027:
URL: https://github.com/apache/incubator-gobblin/pull/3027#discussion_r439162340
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/job_monitor/AvroJobSpecKafkaJobMonitor.java
##########
@@ -108,10 +102,10 @@ protected void createMetrics() {
/**
* Creates a {@link JobSpec} or {@link URI} from the {@link AvroJobSpec}
record.
* @param record the record as an {@link AvroJobSpec}
- * @return a {@link JobSpec} or {@link URI} wrapped in a {@link Collection}
of {@link Either}
+ * @return a {@link JobSpec}
*/
@Override
- public Collection<Either<JobSpec, URI>> parseJobSpec(AvroJobSpec record) {
+ public Collection<JobSpec> parseJobSpec(AvroJobSpec record) {
Review comment:
In KafkaJobMonitor, caller of this api is supposed to decide whether it
is an insert/update or delete type of job spec based on Either c. I could not
found any other way to represent a 3rd type of job spec. It also makes less
sense to me, because the job spec itself has sufficient information for caller
to decide what kind of request it is; jobspec's metadata has a field VERB to
store this information.
Yes it is a backward incompatible change, I changed all the implementations
of KafkaJobMonitor using this new return type, including this one
(AvroJobSpecKafkaJobMonitor). If there still is any implementation of
KafkaJobMonitor by external developers, probably this change can help them how
to remove either?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 444674)
Time Spent: 50m (was: 40m)
> cancel a gaas flow when the dag manager is disabled
> ---------------------------------------------------
>
> Key: GOBBLIN-1187
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1187
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
