[
https://issues.apache.org/jira/browse/GOBBLIN-1187?focusedWorklogId=448055&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448055
]
ASF GitHub Bot logged work on GOBBLIN-1187:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/20 21:28
Start Date: 18/Jun/20 21:28
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3027:
URL: https://github.com/apache/incubator-gobblin/pull/3027#discussion_r442500219
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java
##########
@@ -385,6 +400,42 @@ public void remove(Spec spec, Properties headers) throws
IOException {
}
}
+ @Subscribe
+ public void handleKillFlowEvent(KillFlowEvent killFlowEvent) {
Review comment:
I am a little concerned with the extent of hacks we are introducing
based on whether the dag manager mode is enabled. I think we should evaluate
doing this against just making DagManager the standard de-facto code path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 448055)
Time Spent: 2h 40m (was: 2.5h)
> cancel a gaas flow when the dag manager is disabled
> ---------------------------------------------------
>
> Key: GOBBLIN-1187
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1187
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
