[ 
https://issues.apache.org/jira/browse/GOBBLIN-1187?focusedWorklogId=448707&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448707
 ]

ASF GitHub Bot logged work on GOBBLIN-1187:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Jun/20 23:16
            Start Date: 19/Jun/20 23:16
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on a change in pull request 
#3027:
URL: https://github.com/apache/incubator-gobblin/pull/3027#discussion_r443074977



##########
File path: 
gobblin-modules/gobblin-kafka-09/src/main/java/org/apache/gobblin/kafka/writer/Kafka09DataWriter.java
##########
@@ -84,6 +83,7 @@ public long bytesWritten() {
       };
 
   private final Producer<K, V> producer;
+  @EqualsAndHashCode.Include

Review comment:
       We instantiate different executors(producers) for different kafka topics 
to send specs to. So I found only topic name to be relevant in comparing 
producers.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 448707)
    Time Spent: 2h 50m  (was: 2h 40m)

> cancel a gaas flow when the dag manager is disabled
> ---------------------------------------------------
>
>                 Key: GOBBLIN-1187
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1187
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to