[
https://issues.apache.org/jira/browse/GORA-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707224#comment-13707224
]
Lewis John McGibbney commented on GORA-229:
-------------------------------------------
Hi Apos. Thanks v much for the patch. Two things,
* All gora-cassandra stuff seems to be absent in the new patch.
* There ar three methods in TestHBaseStore which are overridden which should
also be annotated with @Ignore.
Just a quick note, JUnit API also enables us to write the following
{code:xml}
@Ignore("not ready yet")
@Test public void something() { ...
{code}
This means that if there is any reasoning or comments accompanying the code
this can be shifted in to the @Ignore annotation input.
It is entirely up to you Apos, but it is very useful for other developers if
you are able to leave patches as they progress here in Jira as oppose to
removing them.
Thank you so much Apos.
> Use @Ignore for unimplemented functionality to identify absent tests
> ---------------------------------------------------------------------
>
> Key: GORA-229
> URL: https://issues.apache.org/jira/browse/GORA-229
> Project: Apache Gora
> Issue Type: Bug
> Components: testing
> Affects Versions: 0.3
> Reporter: Lewis John McGibbney
> Assignee: Apostolos Giannakidis
> Priority: Minor
> Labels: newbie
> Fix For: 0.4
>
> Attachments: GORA-229.patch
>
>
> We support JUnit 4.10, but actually use it!!!
> All imports should be org.junit instead of junit.framework.*
> We also do not make use of the very handy @Ignore annotation provided by
> JUnit 4.X... we should.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
