[ 
https://issues.apache.org/jira/browse/GORA-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713905#comment-13713905
 ] 

Lewis John McGibbney commented on GORA-229:
-------------------------------------------

Hi Apos, sorry for taking a while to get around to this.
I cannot apply the patch to SVN. Right now (until folks wish to push the 
migration to Git for Gora) we use SVN for all version control.
You can generate your SVN compatible patch as follows

{code:xml}
git diff --no-prefix trunk > $ISSUE_NUMBER.patch
{code} 

I also notice that the formatting in this patch seems to be all off. It looks 
like in many instances line indents are replaced by tabs instead of two spaces.
Thanks Apos. Great work, this is turning out to be a large patch indeed!!!
                
> Use @Ignore for unimplemented functionality to identify absent tests 
> ---------------------------------------------------------------------
>
>                 Key: GORA-229
>                 URL: https://issues.apache.org/jira/browse/GORA-229
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: testing
>    Affects Versions: 0.3
>            Reporter: Lewis John McGibbney
>            Assignee: Apostolos Giannakidis
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.4
>
>         Attachments: GORA-229.patch
>
>
> We support JUnit 4.10, but actually use it!!!
> All imports should be org.junit instead of junit.framework.*
> We also do not make use of the very handy @Ignore annotation provided by 
> JUnit 4.X... we should.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to