[
https://issues.apache.org/jira/browse/GORA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892554#comment-13892554
]
Lewis John McGibbney commented on GORA-94:
------------------------------------------
Hi [~alparslan.avci], GORA-94v11.patch is much much better. Only thing it lacks
in Javadoc ;)
Some observations
* Do we need to always setHeaders as follows --> webPage.setHeaders(new
HashMap<CharSequence, CharSequence>()); ? What happens if we just access the
headers field without initiating a *new* HashMap? Do we still get NPE? I though
the builder build() method would initiate default empty HashMap?
* Do you have any idea what is the current issue with PersistentBase#clear()
method? I am puzzled as to why it is not clearing dirty state of object field.
> Upgrade to Apache Avro 1.7.x
> ----------------------------
>
> Key: GORA-94
> URL: https://issues.apache.org/jira/browse/GORA-94
> Project: Apache Gora
> Issue Type: Improvement
> Components: build process, storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Assignee: Ed Kohlwey
> Fix For: 0.4
>
> Attachments: GORA-94-v2.patch, GORA-94-v3.patch, GORA-94-v4.patch,
> GORA-94.patch, GORA-94v10.patch, GORA-94v11.patch, GORA-94v12.patch,
> GORA-94v6.diff, GORA-94v7.patch, GORA-94v8.patch, GORA-94v9.patch,
> GORA_94v5.patch
>
>
> I am not sure what this involves as of yet but I have a small feeling that
> it's going to be some reasonably major work...
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
