[
https://issues.apache.org/jira/browse/GORA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913179#comment-13913179
]
Lewis John McGibbney commented on GORA-94:
------------------------------------------
Hi [~alparslan.avci], thanks for comments. Apologies about my delay in getting
back to you.
bq. I think, this is the true algorithm for testing the update...
Yes I agree here. A simple test at the end, in addition to checking the _odd_
indexed urls in the outlinks map would be for us to get the webpage from the
datastore and check the total number of entries in the outlink map. This would
mean we add the the algorithm by doing the final check from the persisted
object. wdyt?
bq. ...since HBaseStore does not clear the map after DirtyMapWrapper.clear()
method is called.
I think that this is a big that we should correct. #clear methods should remove
all entires from the data structure leaving it as an empty data structure (not
null).
I propose that we
1. Keep your improvements for adding the following methods
+ DataStoreTestUtil.testUpdateWebPagePutToArray(webPageStore);
+ DataStoreTestUtil.testUpdateWebPagePutToNotNullableMap(webPageStore);
+ DataStoreTestUtil.testUpdateWebPagePutToNullableMap(webPageStore);
+ DataStoreTestUtil.testUpdateWebPageRemoveMapEntry(webPageStore);
+ DataStoreTestUtil.testUpdateWebPageRemoveField(webPageStore);
2. Revert the test algorithm for testUpdate to the implementation currently in
trunk
3. Fix datastores in accordance with this.
One final comment. I feel that we should maybe add test cases for
+ DataStoreTestUtil.testUpdateWebPagePutToNotNullableArray(webPageStore);
+ DataStoreTestUtil.testUpdateWebPagePutToNullableArray(webPageStore);
+ DataStoreTestUtil.testUpdateWebPageRemoveArrayEntry(webPageStore);
This way we would really make explicit the semantics for *dirtyable* data
structures.
If you can comment on the stuff above then I will get to work on these
implementations.
Thanks for your comments.
> Upgrade to Apache Avro 1.7.x
> ----------------------------
>
> Key: GORA-94
> URL: https://issues.apache.org/jira/browse/GORA-94
> Project: Apache Gora
> Issue Type: Improvement
> Components: build process, storage
> Affects Versions: 0.2
> Reporter: Lewis John McGibbney
> Assignee: Ed Kohlwey
> Fix For: 0.4
>
> Attachments: GORA-94-v2.patch, GORA-94-v3.patch, GORA-94-v4.patch,
> GORA-94.patch, GORA-94v10.patch, GORA-94v11.patch, GORA-94v12.patch,
> GORA-94v6.diff, GORA-94v7.patch, GORA-94v8.patch, GORA-94v9.patch,
> GORA_94v5.patch
>
>
> I am not sure what this involves as of yet but I have a small feeling that
> it's going to be some reasonably major work...
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
