[ 
https://issues.apache.org/jira/browse/GORA-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942448#comment-14942448
 ] 

ASF GitHub Bot commented on GORA-439:
-------------------------------------

Github user renato2099 commented on the pull request:

    https://github.com/apache/gora/pull/43#issuecomment-145287775
  
    I am in favour of this, but yeah we might discuss about the API some more 
to see whether it makes sense to keep what. I mean right now, if those 
parameters are not being used, sure maybe we can take them out, but I think we 
should look into why they were put there e.g. passing the dataStore object into 
the GoraMapper, is this because we can get it through the Query object? I think 
most of the others are a lot more straight forward.


> Remove Unused Method Parameters
> -------------------------------
>
>                 Key: GORA-439
>                 URL: https://issues.apache.org/jira/browse/GORA-439
>             Project: Apache Gora
>          Issue Type: Improvement
>            Reporter: Furkan KAMACI
>            Assignee: Furkan KAMACI
>            Priority: Minor
>             Fix For: 0.7
>
>
> Remove unused method parameters and make API signatures clean.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to