[
https://issues.apache.org/jira/browse/GORA-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943987#comment-14943987
]
ASF GitHub Bot commented on GORA-439:
-------------------------------------
Github user kamaci commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-145662887
Unused method parameters may lead a potential bug. Here is a list of what
I've changed:
* CassandraSuperColumn.java#getUnionIndex(String fieldName,
HColumn<ByteBuffer, ByteBuffer> uc)
* QueryCounter.java#createJob(DataStore<K,T> dataStore, Query<K,T> query)
* QueryCounter.java#countQuery(DataStore<K,T> dataStore, Query<K,T> query)
* WordCount.java#createJob(DataStore<String,WebPage> inStore,
Query<String,WebPage> query, DataStore<String,TokenDatum> outStore)
* GoraInputFormat.java#setInputPath(PartitionQuery<K,T> partitionQuery,
TaskAttemptContext context)
* GoraInputFormat.java#setInput(Job job, Query<K1,V1> query,
DataStore<K1,V1> dataStore, boolean reuseObjects)
* GoraMapper.java#initMapperJob(Job job, Query<K1,V1> query,
DataStore<K1,V1> dataStore, Class<K2> outKeyClass, Class<K2> outKeyClass,
Class<V2> outValueClass, Class<? extends GoraMapper> mapperClass, Class<?
extends Partitioner> partitionerClass, boolean reuseObjects)
* GoraMapper.java#initMapperJob(Job job, Query<K1,V1> query,
DataStore<K1,V1> dataStore, Class<K2> outKeyClass, Class<K2> outKeyClass,
Class<V2> outValueClass, Class<? extends GoraMapper> mapperClass, boolean
reuseObjects)
* IOUtils.java#serialize(OutputStream os, SpecificDatumWriter<T>
datumWriter, Schema schema, T object)
* IOUtils.java#serialize(SpecificDatumWriter<T> datumWriter, Schema schema,
T object)
* IOUtils.java#deserialize(InputStream is, SpecificDatumReader<T>
datumReader, Schema schema, T object)
* IOUtils.java#deserialize(byte[] bytes, SpecificDatumReader<T>
datumReader, Schema schema, T object)
* DataStoreTestUtil.java#createEmployee(DataStore<K, Employee> dataStore)
* DataStoreTestUtil.java#createWebPage(DataStore<K, Employee> dataStore)
* DataStoreTestUtil.java#createBoss(DataStore<K, Employee> dataStore)
* MongoMapping.java#addClassField(String docNameFromMapping, String
classFieldName, String docFieldName, String fieldType)
> Remove Unused Method Parameters
> -------------------------------
>
> Key: GORA-439
> URL: https://issues.apache.org/jira/browse/GORA-439
> Project: Apache Gora
> Issue Type: Improvement
> Reporter: Furkan KAMACI
> Assignee: Furkan KAMACI
> Priority: Minor
> Fix For: 0.7
>
>
> Remove unused method parameters and make API signatures clean.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
