[
https://issues.apache.org/jira/browse/GORA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942909#comment-14942909
]
ASF GitHub Bot commented on GORA-240:
-------------------------------------
GitHub user lewismc opened a pull request:
https://github.com/apache/gora/pull/45
GORA-240 Tests for MemStore
Hi Folks,
This PR is not 100% yet and I wanted to post it to kick off some
conversation regarding behavior of MemStore. First though, this PR
* Fixes issues with
[GORA-446](https://issues.apache.org/jira/browse/GORA-446)
* Fixes [GORA-125](https://issues.apache.org/jira/browse/GORA-125) making
logging libraries consistent across the codebase and modules.
* Implements logic for query execution and results generation please see
MemStore#execute
* Finally, addresses
[GORA-240](https://issues.apache.org/jira/browse/GORA-240) We have to @Ignore
testDeleteByQueryFields and implement testMemStoreDeleteByQueryFields which is
basically the same test however we explicitly set the start and end keys for
the Query.
This PR is not 100% yet there are two tests which are currently failing
however I wanted to put the code here for us to talk about MemStore behaviour.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/gora GORA-240
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/45.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #45
----
commit 11b1d7accbe787010218152b6eb25b17ecbe5809
Author: Lewis John McGibbney <[email protected]>
Date: 2015-10-03T19:52:21Z
GORA-240 Tests for MemStore
commit 209d6632cb98a6c76a3c634f94222cb8b0d135ed
Author: Lewis John McGibbney <[email protected]>
Date: 2015-10-05T04:35:11Z
GORA-240 Tests for MemStore
----
> Tests for MemStore
> ------------------
>
> Key: GORA-240
> URL: https://issues.apache.org/jira/browse/GORA-240
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-core
> Affects Versions: 0.3
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Fix For: 0.7
>
>
> We currently have no tests for MemStore... hence the reason that we have bugs
> which are logged in Jira.
> We should have some simple testing (extension of core unit test suite) for
> MemStore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
