[
https://issues.apache.org/jira/browse/GORA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942915#comment-14942915
]
ASF GitHub Bot commented on GORA-240:
-------------------------------------
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/45#issuecomment-145428704
Current issues include the following.
```
java.lang.NullPointerException
at
org.apache.gora.store.impl.DataStoreBase.getFields(DataStoreBase.java:172)
at
org.apache.gora.store.impl.DataStoreBase.getFieldsToQuery(DataStoreBase.java:168)
at org.apache.gora.memory.store.MemStore.execute(MemStore.java:148)
at org.apache.gora.query.impl.QueryBase.execute(QueryBase.java:73)
at
org.apache.gora.store.DataStoreTestUtil.assertNumResults(DataStoreTestUtil.java:878)
at
org.apache.gora.memory.store.MemStoreTest.testMemStoreDeleteByQueryFields(MemStoreTest.java:126)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
at
org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
```
The issue here is that we attempt to execute DataStoreBase#getFields with
the following logic
```
List<Field> schemaFields =
beanFactory.getCachedPersistent().getSchema().getFields();
```
This throws NPE.
Any ideas where we should ensure that this is prevented?
> Tests for MemStore
> ------------------
>
> Key: GORA-240
> URL: https://issues.apache.org/jira/browse/GORA-240
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-core
> Affects Versions: 0.3
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Fix For: 0.7
>
>
> We currently have no tests for MemStore... hence the reason that we have bugs
> which are logged in Jira.
> We should have some simple testing (extension of core unit test suite) for
> MemStore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
