[
https://issues.apache.org/jira/browse/GORA-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034361#comment-16034361
]
ASF GitHub Bot commented on GORA-255:
-------------------------------------
GitHub user nishadi opened a pull request:
https://github.com/apache/gora/pull/107
GORA-255 Remove deprecated methods from data store test base
This PR removes the deprecated methods from data store test base.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nishadi/gora issue-255
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit 25188aacd98cbcfeec79026a285fb7b1f37187eb
Author: nishadi <[email protected]>
Date: 2017-06-02T09:13:34Z
Remove deprecated methods from data store test base
----
> Remove deprecated methods from DataStoreTestBase
> -------------------------------------------------
>
> Key: GORA-255
> URL: https://issues.apache.org/jira/browse/GORA-255
> Project: Apache Gora
> Issue Type: Improvement
> Components: testing
> Affects Versions: 0.4
> Reporter: Apostolos Giannakidis
> Assignee: Apostolos Giannakidis
> Priority: Minor
> Labels: test
> Fix For: 0.8
>
>
> The abstract class DataStoreTestBase contains 2 deprecated methods:
> DataStore<String, Employee> createEmployeeDataStore()
> DataStore<String, WebPage> createWebPageDataStore()
> These methods were useful in the past but they seem not to be useful now.
> I believe that they should be removed from the abstract class
> DataStoreTestBase. Their concrete implementations from the subclasses that
> extend the DataStoreTestBase should also be removed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
