[
https://issues.apache.org/jira/browse/GORA-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039000#comment-16039000
]
Kevin Ratnasekera commented on GORA-255:
----------------------------------------
[~alfonso.nishikawa] I locally tested the PR before merging to master, tests
passed without an issue. Do you think we missed on something/or whether we
could improve on this mock impl? :)
Regards
Kevin
> Remove deprecated methods from DataStoreTestBase
> -------------------------------------------------
>
> Key: GORA-255
> URL: https://issues.apache.org/jira/browse/GORA-255
> Project: Apache Gora
> Issue Type: Improvement
> Components: testing
> Affects Versions: 0.4
> Reporter: Apostolos Giannakidis
> Assignee: Nishadi Kirielle
> Priority: Minor
> Labels: test
> Fix For: 0.8
>
>
> The abstract class DataStoreTestBase contains 2 deprecated methods:
> DataStore<String, Employee> createEmployeeDataStore()
> DataStore<String, WebPage> createWebPageDataStore()
> These methods were useful in the past but they seem not to be useful now.
> I believe that they should be removed from the abstract class
> DataStoreTestBase. Their concrete implementations from the subclasses that
> extend the DataStoreTestBase should also be removed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
