Github user djkevincr commented on a diff in the pull request:
    --- Diff: 
    @@ -0,0 +1,279 @@
    + *  Licensed to the Apache Software Foundation (ASF) under one or more
    + *  contributor license agreements.  See the NOTICE file distributed with
    + *  this work for additional information regarding copyright ownership.
    + *  The ASF licenses this file to You under the Apache License, Version 2.0
    + *  (the "License"); you may not use this file except in compliance with
    + *  the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + */
    +import org.apache.avro.Schema;
    --- End diff --
    I think by design, this CassandraStore class should be free from AVRO 
related imports since you only implement DataStore<K, T> interface.
    AVRO related imports should only be resided in AvroSerializer class. 
    Native datastax related imports should only be resided in NativeSerializer 
    That way CassandraStore  is decoupled from AVRO related dependencies. 
    I went through your code this AVRO import has only been used in one 
location in persistentSchema class level variable. I think you can easily get 
rid of this bit of code change, may be you change 
CassandraSerializer.getSerializer() method by passing BeanFactory<K, T> 
beanFactory directly rather assigning to class level variable.
    I think one this type of design would be start point, one day Gora should 
be refactored to support pluggable serializers not just AVRO. WDYT @lewismc 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to