Github user djkevincr commented on the issue:
    @madhawa-gunasekara This is excellent work :) I have reviewed you PR, I was 
not able find anything major, however I have added some comments, please check 
them out. Also code needs bit of a clean up as well, please go through the code 
again and see cases where you can improve the code .
    I agree some of the concerns highlighted by @renato2099 in this thread. So 
I am waiting @renato2099 @lewismc to have a look and comment on updated PR.
    I have also locally tested your PR, I am glad to say I did not encounter 
any issue. :) 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to