ASF GitHub Bot commented on GORA-497:
Github user djkevincr commented on a diff in the pull request:
@@ -0,0 +1,279 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
--- End diff --
I think by design, this CassandraStore class should be free from AVRO
related imports since you only implement DataStore<K, T> interface.
AVRO related imports should only be resided in AvroSerializer class.
Native datastax related imports should only be resided in NativeSerializer
That way CassandraStore is decoupled from AVRO related dependencies.
I went through your code this AVRO import has only been used in one
location in persistentSchema class level variable. I think you can easily get
rid of this bit of code change, may be you change
CassandraSerializer.getSerializer() method by passing BeanFactory<K, T>
beanFactory directly rather assigning to class level variable.
I think one this type of design would be start point, one day Gora should
be refactored to support pluggable serializers not just AVRO. WDYT @lewismc
> Migrate CassandraThrift to CQL
> Key: GORA-497
> URL: https://issues.apache.org/jira/browse/GORA-497
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-cassandra
> Reporter: Madhawa Gunasekara
> Assignee: Madhawa Gunasekara
> Labels: gsoc2017
> Fix For: 0.8
This message was sent by Atlassian JIRA