ASF GitHub Bot commented on GORA-497:

Github user djkevincr commented on the issue:

    @madhawa-gunasekara This is excellent work :) I have reviewed you PR, I was 
not able find anything major, however I have added some comments, please check 
them out. Also code needs bit of a clean up as well, please go through the code 
again and see cases where you can improve the code .
    I agree some of the concerns highlighted by @renato2099 in this thread. So 
I am waiting @renato2099 @lewismc to have a look and comment on updated PR.
    I have also locally tested your PR, I am glad to say I did not encounter 
any issue. :) 

> Migrate CassandraThrift to CQL 
> -------------------------------
>                 Key: GORA-497
>                 URL: https://issues.apache.org/jira/browse/GORA-497
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-cassandra
>            Reporter: Madhawa Gunasekara
>            Assignee: Madhawa Gunasekara
>              Labels: gsoc2017
>             Fix For: 0.8

This message was sent by Atlassian JIRA

Reply via email to