djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312780949
########## File path: gora-benchmark/pom.xml ########## @@ -0,0 +1,186 @@ +<?xml version="1.0"?> +<!-- ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with ~ + this work for additional information regarding copyright ownership. ~ The + ASF licenses this file to You under the Apache License, Version 2.0 ~ (the + "License"); you may not use this file except in compliance with ~ the License. + You may obtain a copy of the License at ~ ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ ~ Unless required by applicable law or agreed to in writing, software ~ + distributed under the License is distributed on an "AS IS" BASIS, ~ WITHOUT + WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. ~ See the + License for the specific language governing permissions and ~ limitations + under the License. --> +<project + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"; + xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.gora</groupId> + <artifactId>gora</artifactId> + <version>0.9-SNAPSHOT</version> + </parent> + <artifactId>gora-benchmark</artifactId> Review comment: Currently you have not added the new benchmark module to parent pom under modules section, that means this module is omitted when entire project is built from root parent pom. EG:- ``` <modules> <module>gora-compiler</module> <module>gora-compiler-cli</module> <module>gora-core</module> <module>gora-pig</module> <module>gora-accumulo</module> <module>gora-cassandra</module> <module>gora-goraci</module> <module>gora-hbase</module> <module>gora-infinispan</module> <module>gora-jcache</module> <module>gora-orientdb</module> <module>gora-lucene</module> <module>gora-dynamodb</module> <module>gora-couchdb</module> <module>gora-maven-plugin</module> <module>gora-mongodb</module> <module>gora-solr</module> <module>gora-aerospike</module> <module>gora-ignite</module> <module>gora-tutorial</module> <module>gora-benchmark</module> <module>sources-dist</module> </modules> ``` I think we once we have these YCSB artifacts from maven central, we can enable benchmark module to build process. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
