djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r312782893
########## File path: gora-benchmark/src/main/java/org/apache/gora/benchmark/GoraBenchmarkClient.java ########## @@ -0,0 +1,271 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gora.benchmark; + +import java.util.Arrays; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Properties; +import java.util.Set; +import java.util.Vector; +import org.apache.gora.query.Query; +import org.apache.gora.query.Result; +import org.apache.gora.store.DataStore; +import org.apache.gora.store.DataStoreFactory; +import org.apache.gora.util.GoraException; +import org.apache.hadoop.conf.Configuration; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import com.yahoo.ycsb.ByteIterator; +import com.yahoo.ycsb.DB; +import com.yahoo.ycsb.DBException; +import com.yahoo.ycsb.Status; +import com.yahoo.ycsb.StringByteIterator; +import com.yahoo.ycsb.workloads.CoreWorkload; +import org.apache.gora.benchmark.generated.User; + +/** + * The Class GoraBenchmarkClient + * + * @author sc306 This class extends the Yahoo! Cloud Service Benchmark benchmark + * {@link #com.yahoo.ycsb.DB DB} class to provide functionality for + * {@link #insert(String, String, HashMap) insert}, + * {@link #read(String, String, Set, HashMap) read}, + * {@link #scan(String, String, int, Set, Vector) scan} and + * {@link #update(String, String, HashMap) update} methods as per Apache + * Gora implementation. + */ +public class GoraBenchmarkClient extends DB { + private static final Logger LOG = LoggerFactory.getLogger(GoraBenchmarkClient.class); + private static final String FIELDS[] = User._ALL_FIELDS; + private static volatile boolean executed; + public static int fieldCount; + /** This is only for set to array conversion in {@link read()} method */ + private String[] DUMMY_ARRAY = new String[0]; + DataStore<String, User> dataStore; + GoraBenchmarkUtils goraBenchmarkUtils = new GoraBenchmarkUtils(); Review comment: Usually we don't instantiate utility classes. Utility classes should only have set of static class level methods, so that you can call without instantiating. Eg:- GoraBenchmarkUtils.generateMappingFile() One attribute of a utility classes is that, it usually never maintain state inside the class. I think we should consider renaming this class appropriately. Otherwise we should consider making all the methods in GoraBenchmarkUtils as static, you should only invoke methods as above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
